Add silence skipping to remove long delays before and after speech #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this app in English there is something like a 0.5s delay after every sentence making the TTS very annoying and slow.
This change adds a silence skipping audio processor before Sonic processing happens which makes things much nicer.
It's currently non-optional but it shouldn't be too hard to make it configurable.
There's also a lot of other changes like increasing the minimum api, upgrading exoplayer, and fixing Opus non-exo decoding streaming as well as some other minor changes so I don't really expect this PR to be used as is but it can be used as reference for future changes.
The InputStreamMediaDataSource changes are particularly important though as Opus streaming decoding is broken without it.