feat: 793 reservation 라우트 경로 정리 #795
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
개인 예약 조회, 예약 조회, 도서별 예약 조회 부분 작성완료, 예약 생성, 예약 취소 부분 작성 필요
JeongJiHwan
had a problem deploying
to
development
GitHub Actions
Failure
…-reservation-라우트-경로-정리
JeongJiHwan
temporarily deployed
to
development
GitHub Actions
Inactive
JeongJiHwan
changed the title
JeongJiHwan
changed the title
예약 취소 api 에 cancel 을 명시적으로 표현하는 쪽이 더 낫다고 판단하여 수정하였습니다.
JeongJiHwan
temporarily deployed
to
development
GitHub Actions
Inactive
jimin52
reviewed
Dec 3, 2023
| export const reservationsContract = c.router({ | ||
| getMine: { | ||
| method: 'GET', | ||
| path: '/mypage/reservations', |
There was a problem hiding this comment.
/reservations/me
/me/reservations
로 해도 좋을 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
Reservation 라우트 경로 정리 #793 정리 후 reservations contracts 작성
v1 : [GET] api/reservations/
본인이 예약한 책을 확인할 수 있는 api로 확인되나 마이페이지에서는 user api에서 예약한 도서를 확인하고 있습니다.
[GET] api/mypage/reservations 로 변경하는게 맞을까요?
이 부분도 일단 contract에 추가해 두었습니다. 피드백이 있다면 부탁드립니다.
[get] reservations response에서 확인되는 status 값은
0. 예약중
로 확인을 했습니다.
[get] reservations request query 에서의 filter 값은
으로 확인했습니다.