Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web) ✨ new config to hide login button on WaitForOwnerDialog #14502

Merged
merged 6 commits into from May 21, 2024

Conversation

HannesOberreiter
Copy link
Contributor

If the guest joins before the host and jitsi is setup with JWT only authentication the WaitForOwnerDialog shows a "Login" button, which is without use in this case.

  • Added a config option to hide the login button showing up.
  • Added new text if login button is hidden

Translations are added for EN, DE, HU. Left empty string for the other translations.

config.hideLoginButton=false
config.hideLoginButton=false

config.hideLoginButton=true
config.hideLoginButton=true

A relevant discussion/question I found in the community forum: https://community.jitsi.org/t/how-to-disable-login-pop-up-along-with-supporting-jwt-authentication/110517

Contribution Agreement was signed as company, Certible GmbH.

Cheers
Hannes

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

config.js Outdated Show resolved Hide resolved
saghul
saghul previously approved these changes Mar 21, 2024
@saghul
Copy link
Member

saghul commented Mar 21, 2024

Jenkins please test this please.

@HannesOberreiter
Copy link
Contributor Author

Updated conflicts with translation files.

Copy link
Member

@damencho damencho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the empty string you added in all translations for WaitForHostNoAuthMsg, so it can default to the English instead of empty string where translation is missing?

Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @damencho note for ourselves: perhaps we should conisder adding an auth section to config.js...

@saghul saghul merged commit 76e3608 into jitsi:master May 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants