-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web) ✨ new config to hide login button on WaitForOwnerDialog #14502
Conversation
Hi, thanks for your contribution! |
Jenkins please test this please. |
Updated conflicts with translation files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please remove the empty string you added in all translations for WaitForHostNoAuthMsg
, so it can default to the English instead of empty string where translation is missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @damencho note for ourselves: perhaps we should conisder adding an auth
section to config.js...
If the guest joins before the host and jitsi is setup with JWT only authentication the WaitForOwnerDialog shows a "Login" button, which is without use in this case.
Translations are added for EN, DE, HU. Left empty string for the other translations.
config.hideLoginButton=false
config.hideLoginButton=true
A relevant discussion/question I found in the community forum: https://community.jitsi.org/t/how-to-disable-login-pop-up-along-with-supporting-jwt-authentication/110517
Contribution Agreement was signed as company, Certible GmbH.
Cheers
Hannes