Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SmileysPanel ux #14550

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HazemAbdo
Copy link
Contributor

Fixed (Fix emoji picker ux) #14549
New emoji picker behavior :

  • If closed it opens only if click IconFaceSmile
    - If opend it closes if click in any place outside SmileysPanel
    - When choose an icon it keeps open
emoji_new.mp4
  • Why I need input icon ref ?
    • If click on IconFaceSmile it triggers onClickOutside of SmileysPanel which closes the panel but on the same time it triggers clicking on IconFaceSmile which opens the panel so the panel will not be closed in this case
  • I want to ask for a better way to pass inputIconRef to the icon without wrapping it with a div. I went with this solution to not make a lot of changes into abstract components react/features/base/react/components/AbstractContainer.ts

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@HazemAbdo HazemAbdo changed the title fix(SimleysPanel):fix SimleysPanel ux fix SmileysPanel ux Mar 26, 2024
@HazemAbdo
Copy link
Contributor Author

I have already signed the CLA

@saghul saghul requested a review from mihhu March 28, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants