-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update package clipboard to @react-native-clipboard/clipboard #14560
base: master
Are you sure you want to change the base?
Conversation
Hi, thanks for your contribution! |
@@ -916,4 +916,4 @@ SPEC CHECKSUMS: | |||
|
|||
PODFILE CHECKSUM: ec00682c7062a323dff24a3c3643ca0bbb420d01 | |||
|
|||
COCOAPODS: 1.14.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't change the CocoaPods version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, it's just from template
@@ -1031,7 +1031,8 @@ | |||
OTHER_CPLUSPLUSFLAGS = "$(inherited)"; | |||
OTHER_LDFLAGS = ( | |||
"$(inherited)", | |||
" ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this change necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, it's just from template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Xcode version did you use?
"@types/react": "17.0.14", | ||
"@types/react-dom": "17.0.14" | ||
} | ||
"name": "jitsi-meet", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't reformat the file please. Keep your changes to a minimum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, it's just from template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't matter where it comes from, we can't accept PRs that reformat files just because.
diff --git a/node_modules/@giphy/js-analytics/dist/send-pingback.js b/node_modules/@giphy/js-analytics/dist/send-pingback.js | ||
index 989f0ff..149e77c 100644 | ||
--- a/node_modules/@giphy/js-analytics/dist/send-pingback.js | ||
+++ b/node_modules/@giphy/js-analytics/dist/send-pingback.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not remove our patches please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh sorry, i will revise
change package clipboard to @react-native-clipboard/clipboard
because can't run on react-native 0.73.x