Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add support for jiconop #14627

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Khalidmamdou7
Copy link

@Khalidmamdou7 Khalidmamdou7 commented Apr 13, 2024

This PR is not intended for merge
While working on GSoC Project to implement jiconop for websockets, I needed to enable jiconop for BOSH to understand the concepts behind it and experiment it. So, This PR is part of this guide, in case anyone needed to do the same.

A previously dropped service jiconop which optimizes the initial connection of BOSH by adding a proxy between clients and the server.

This draft pull request shows the needed changes in jitsi-meet files in order to re-add the support for this abandoned service, in case someone wanted to experiment with it.

A previously dropped service jiconop which optimizes the initial connection of BOSH by adding a proxy between clients and the server.
@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@saghul
Copy link
Member

saghul commented Apr 13, 2024

I'm confused. If this PR is not intended for merging, what is it intended for?

@Khalidmamdou7
Copy link
Author

I'm confused. If this PR is not intended for merging, what is it intended for?

I thought it would be appropriate to use it in this guide. If I should close it, please let me know. Sorry for the confusion

@saghul
Copy link
Member

saghul commented Apr 13, 2024

What is the context here? Why would you like to bring it back? Have you tested using WebSockets?

@Khalidmamdou7
Copy link
Author

What is the context here? Why would you like to bring it back? Have you tested using WebSockets?

For a Gsoc project, I amy work on building a similar oroject for websockets. So, in order to understand the concept I brought it back. And thought that in case someone tried to do the same, this guide may be needed.

@saghul
Copy link
Member

saghul commented Apr 13, 2024

I am one of the GSoC admins, so I suspected that was the case.

Please do mention that in the PR description so people passing by can know the context.

@Khalidmamdou7
Copy link
Author

Done and sorry for the confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants