Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(polls): rework #14645

Merged
merged 18 commits into from May 22, 2024
Merged

feat(polls): rework #14645

merged 18 commits into from May 22, 2024

Conversation

Calinteodor
Copy link
Contributor

@Calinteodor Calinteodor commented Apr 17, 2024

  1. Save poll.
  2. Edit poll.
  3. Save edited poll.
  4. Send poll to other participants.

@Calinteodor Calinteodor marked this pull request as draft April 17, 2024 09:31
@Calinteodor Calinteodor force-pushed the polls-rework branch 3 times, most recently from e74122c to 367ed5a Compare April 30, 2024 08:50
@Calinteodor Calinteodor force-pushed the polls-rework branch 4 times, most recently from fda58db to a403b5b Compare May 14, 2024 16:26
@Calinteodor Calinteodor marked this pull request as ready for review May 14, 2024 16:38
react/features/polls/components/AbstractPollCreate.tsx Outdated Show resolved Hide resolved
react/features/polls/components/AbstractPollCreate.tsx Outdated Show resolved Hide resolved
react/features/polls/components/AbstractPollCreate.tsx Outdated Show resolved Hide resolved
react/features/polls/components/AbstractPollCreate.tsx Outdated Show resolved Hide resolved
react/features/polls/components/AbstractPollCreate.tsx Outdated Show resolved Hide resolved
react/features/polls/reducer.ts Outdated Show resolved Hide resolved
react/features/polls/components/AbstractPollCreate.tsx Outdated Show resolved Hide resolved
react/features/polls/reducer.ts Outdated Show resolved Hide resolved
react/features/polls/middleware.ts Outdated Show resolved Hide resolved
react/features/polls/components/web/PollItem.tsx Outdated Show resolved Hide resolved
@horymury
Copy link
Contributor

I would revisit the cases where ts-ignore is used and check whether we can have a way to get rid of it. Also , I would suggest avoiding using any for type defs except the cases in which there is no way of knowing it.

@Calinteodor
Copy link
Contributor Author

I would revisit the cases where ts-ignore is used and check whether we can have a way to get rid of it. Also , I would suggest avoiding using any for type defs except the cases in which there is no way of knowing it.

Thanks Horatiu! I will look into it!

react/features/polls/types.ts Outdated Show resolved Hide resolved
react/features/polls/types.ts Outdated Show resolved Hide resolved
react/features/polls/components/AbstractPollCreate.tsx Outdated Show resolved Hide resolved
react/features/polls/components/AbstractPollCreate.tsx Outdated Show resolved Hide resolved
react/features/polls/components/AbstractPollCreate.tsx Outdated Show resolved Hide resolved
react/features/polls/components/AbstractPollCreate.tsx Outdated Show resolved Hide resolved
react/features/polls/components/AbstractPollCreate.tsx Outdated Show resolved Hide resolved
react/features/polls/components/AbstractPollCreate.tsx Outdated Show resolved Hide resolved
@Calinteodor Calinteodor changed the title feat(polls): web rework feat(polls): rework May 22, 2024
react/features/polls/functions.ts Outdated Show resolved Hide resolved
react/features/polls/functions.ts Outdated Show resolved Hide resolved
react/features/polls/types.ts Outdated Show resolved Hide resolved
react/features/polls/reducer.ts Outdated Show resolved Hide resolved
react/features/polls/components/native/PollAnswer.tsx Outdated Show resolved Hide resolved
react/features/polls/components/AbstractPollAnswer.tsx Outdated Show resolved Hide resolved
react/features/polls/components/native/PollItem.tsx Outdated Show resolved Hide resolved
react/features/polls/components/web/PollCreate.tsx Outdated Show resolved Hide resolved
react/features/polls/components/web/PollItem.tsx Outdated Show resolved Hide resolved
horymury
horymury previously approved these changes May 22, 2024
horymury
horymury previously approved these changes May 22, 2024
horymury
horymury previously approved these changes May 22, 2024
horymury
horymury previously approved these changes May 22, 2024
@Calinteodor Calinteodor merged commit 3ecc16d into jitsi:master May 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants