fit the emoji panel to message tag #14647
Open
+25
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution! |
|
please review this code |
saghul
requested changes
Apr 20, 2024
| @@ -64,9 +65,11 @@ class ChatInput extends Component<IProps, IState> { | |||
|
|
|||
| state = { | |||
| message: '', | |||
| messages: [], | |||
| showSmileysPanel: false | ||
| }; | ||
|
|
||
|
|
| <div | ||
| className = 'smileys-panel' > | ||
| <SmileysPanel |
There was a problem hiding this comment.
Is this smileys panel used anywhere else now? If not we should delete it.
shawnchin
reviewed
Apr 24, 2024
| onClick = { this._onSubmitMessage } | ||
| onClick={() => { | ||
| this._onSubmitMessage() | ||
| this._toggleSmileysPanel();}} |
There was a problem hiding this comment.
Is this correct? Seems strange to toggle on/off the smiley panel each time a message is sent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fit the emoji panel to message tag
if any issue feel free to contact me via email: viraj123e@gmail.com