ktlint: Do NOT use --apply-to-idea-project #23
Conversation
because it silently overrides the *Java* code style settings. Do not run in the mvn validate phase. Use pre-commit hook instead of pre-push.
|
Don't merge yet, WIP |
|
Shit, good catch. Didn't know this overrides the Java settings (no idea why
it would do that...)
…On Tue, Apr 16, 2019, 11:49 PM bgrozev ***@***.***> wrote:
Don't merge yet, WIP
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#23 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AD1JVZunWzCs5GymFwQFwvRifJJm_TS8ks5vhsP6gaJpZM4c0Tjt>
.
|
|
Yeah, it doesn't seem right. I asked upstream |
|
Ok cool. Btw I looked at it after seeing this and there is a dedicated
maven plugin by someone (https://github.com/gantsign/ktlint-maven-plugin)--i
totally missed that before I guesss. but didn't look at it deeper.
…On Wed, Apr 17, 2019, 6:36 AM bgrozev ***@***.***> wrote:
Yeah, it doesn't seem right. I asked upstream
pinterest/ktlint#378 <pinterest/ktlint#378>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#23 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AD1JVS9ZDg4x-aSY3gEAy85_jH2EDtEUks5vhyN2gaJpZM4c0Tjt>
.
|
|
We can move to the mvn plugin later. I removed running it as part of the maven workflow, because I use Personally I prefer a pre-commit hook (instead of pre-push), otherwise if I only notice when I'm trying to push I might need to rebase to fix earlier commits. But I wouldn't mind having both. I think there must be a way to have them installed automatically on checkout, but I couldn't find out how with a quick seach. Same applies to the jmt commit PR that I'll open tomorrow |
|
No I left a note in the readme and was going to leave it for later. This doesn't change anything, since one has to manually launch |
because it silently overrides the Java code style settings. Do not
run in the mvn validate phase. Use pre-commit hook instead of pre-push.