Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR from Candidate 4C1BB6 #3

Closed
wants to merge 5 commits into from
Closed

PR from Candidate 4C1BB6 #3

wants to merge 5 commits into from

Conversation

jlengstorf
Copy link
Owner

@jlengstorf jlengstorf commented Nov 17, 2018

Anonymized!

Original PR text:

feat(CLI): add a flag for Yarn Plug'n'Play

This pull request is separated in multiple steps

  1. add the new flag and propagate it
  2. add the pnp webpback plugin
  3. fix use of transitive dependencies (not allowed in pnp mode) (luckily these are all inside gatsby's monorepo)
  4. fix "main" in a dependency: facebook/relay#2573 & yarnpkg/yarn#6682 (after I talked to yarn maintainers)
  5. don't use transitive dependencies at "runtime" (i.e. in cache and public folder of a Gatsby app)

The remaining step (5) is not implemented in this PR (because they touch too many internals of Gatsby):

  • ./.cache
  • ./public
  • eslint

These three steps rely heavily on transitive dependencies. For the first two you can fix it likely by making @reach/router, lodash, prop-types, core-js either not used until someone installs it, or using something like require.resolve. For eslint I couldn't dig deeper which part of Gatsby is relevant, and where the modules eslint-plugin-import, eslint-plugin-flowtype should be listed as direct dependencies.

@jlengstorf jlengstorf changed the title PR from Candidate #4C1BB6 PR from Candidate 4C1BB6 Nov 17, 2018
@jlengstorf jlengstorf closed this May 17, 2019
@jlengstorf jlengstorf deleted the candidate-4C1BB6 branch May 17, 2019 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant