Skip to content

Commit

Permalink
Update mocha version & fix should.be API use error.
Browse files Browse the repository at this point in the history
A mocha defect silently ignored this for the previous package-lock mocha
version (5.0.1).

See the following issue and changelog:

mochajs/mocha#3226
https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#502--2018-03-05

Test should have failed in all cases, but false passing occured with older
mocha versions.
  • Loading branch information
jleverenz committed Nov 25, 2018
1 parent 7d1fa82 commit 7453615
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 31 deletions.
59 changes: 30 additions & 29 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -29,7 +29,7 @@
},
"devDependencies": {
"coffee-script": ">= 1.8.0",
"mocha": "^5.0.1",
"mocha": "^5.2.0",
"request": ">= 2.9.203",
"should": "^13.2.1",
"sinon": "^1.17.4"
Expand Down
2 changes: 1 addition & 1 deletion test/index.test.coffee
Expand Up @@ -154,7 +154,7 @@ describe 'livereload server startup', ->
it 'should gracefully handle something running on the same port', (done) ->
new_server = livereload.createServer({debug: true, port: 35729})
new_server.on 'error', (err) ->
err.code.should.be("EADDRINUSE")
err.code.should.be.equal("EADDRINUSE")

done()

Expand Down

0 comments on commit 7453615

Please sign in to comment.