Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Symfony 6 support #26

Conversation

danielsunnerberg
Copy link

Ran tests and tested manually in our code base and auto login functionality worked as expected.

@jmikola
Copy link
Owner

jmikola commented Feb 22, 2023

There is a test failure related to AuthenticationManagerInterface in the following CI build: https://github.com/jmikola/AutoLogin/actions/runs/4224927343/jobs/7366816906#step:7:22

A spent a few minutes digging into Symfony's git history and I believe this is related to the removal of deprecated APIs in symfony/symfony#41613. The CI error above is caused by attempting to mock a non-existent class in AutoLoginListenerTest, but I expect changes will also be required in the AutoLoginListener class itself.

I have not been following changes to Symfony's Security component, but symfony/symfony#33558 may be relevant (also came up while digging through git history).

@danielsunnerberg
Copy link
Author

My apologies, I failed to run the tests using all versions of PHP. We chose to migrate our project to the Symfony native implementation of auto login URLs. Thank you for this project, it filled an important gap in Symfony's offerings.

@jmikola
Copy link
Owner

jmikola commented Mar 4, 2023

Thanks for alerting me to the existence of that feature. It looks like it was introduced in 5.2.

I think the best course of action would be to deprecate this library (and the related bundle) and update the README to point folks to the LoginLink functionality in the Security component.

@danielsunnerberg
Copy link
Author

I think the best course of action would be to deprecate this library (and the related bundle) and update the README to point folks to the LoginLink functionality in the Security component.

I agree. Do you want me to submit a PR to update the README?

@jmikola
Copy link
Owner

jmikola commented Mar 6, 2023

Do you want me to submit a PR to update the README?

No worries. I can do so before archiving both repositories and will aim to do so later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants