Add a output writer for open-falcon agent. #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build jmxtrans 177 completed (commit 6abb40e9c0 by @hsqlu) |
3 tasks
gquintana
requested changes
May 21, 2018
|
|
||
| String json = writer.toString(); | ||
|
|
||
| assertThatJson(json).isArray().ofLength(1); |
There was a problem hiding this comment.
Please, check the content of the JSON: expected fields and their values...
Test with different result value types
There was a problem hiding this comment.
I‘ve added some more test assertions
|
@gquintana I've added some more test cases, please take a review. Thx |
|
@gehel Should this writer be placed in its own Maven module? |
|
@gquintana: Maven modules are used mainly to manage dependencies. So that if someone wants a version of jmxtrans that is < 20Mb, it is possible to do. Since this OutputWriter does not add any dependency that isn't already in output-core, I'm fine with having it there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had created a pr #440 but didn't done it. As it was coded on master branch so I made this pr sepeartely.