InfluxDBWriter : Add "attributesAsTag" parameter #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlaurent9816
force-pushed
the
attributesAsTags
branch
from
274df62
to
1d13d04
Compare
|
2 months after, anybody wants to check this PR? |
gquintana
requested changes
Sep 20, 2018
jmxtrans-core/src/main/java/com/googlecode/jmxtrans/JmxTransformer.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * The {@link ImmutableSet} of {@link ResultAttribute} attributes of | ||
| * {@link Result} that will be written as {@link Point} tags | ||
| */ | ||
| private final ImmutableSet<ResultAttribute> resultAttributesToWriteAsTags; | ||
| @Nonnull private final ImmutableSet<ResultAttribute> resultAttributesToWriteAsTags; |
There was a problem hiding this comment.
tags, resultAttributesToWriteAsTags, typeNamesAsTags, attributesAsTags...
I wonder whether it would be cleaner to have a List<TagSupplier>, TagSupplier being a poorly named functional interface to extract tags from server/query/result.
There was a problem hiding this comment.
I'll see if I can do something like that.
| //Creates a tag map, associated by the typeName. | ||
| //Results fields with the same typeName will receive the same tag values. | ||
| HashMap<String,HashMap<String, String>> attrTagByTypeName = newHashMap(); | ||
| if (!attributesAsTags.isEmpty()) { |
There was a problem hiding this comment.
Extracting a method may make it more readable.
Is it possible to convert HashMap<HashMap> into a Map<Map>?
There was a problem hiding this comment.
No problem, it will be done in the next commit.
...trans-output-influxdb/src/main/java/com/googlecode/jmxtrans/model/output/InfluxDbWriter.java
Show resolved
Hide resolved
nlaurent9816
force-pushed
the
attributesAsTags
branch
from
6d3e5b0
to
1d13d04
Compare
List of attributes which won't be written as fields in InfluxDB, but as tags associated to the results-fields with the same typeNames value.
nlaurent9816
force-pushed
the
attributesAsTags
branch
from
1d13d04
to
ed09588
Compare
- Change HashMap to Map - extract "attributeAsTag" process into a method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In InfluxDB, you can store values as tag or as fields. Tags are indexed but can only be Strings, fields are not indexed but suuports more data formats. (See here.) Actually, the InfluxDbWriter stores every attributes value (results from queries) as fields. If this format is adapted for metrics (counters, averages, etc...), you can have performance issues when reading if you try to filter with them. Tags are more adapted for filtering, that's why it is recommended to store IDs, names, metadata, etc... as tags. Actually, only JMX port (with reportJmxPortAsTag parameter), typeName, objDomain, className, attributeName (with resultTags parameter) and full custom tags are written. "attributesAsTag" is a list of attributes to write as tags instead of fields.
I also have a question: How can I also edit the Wiki pages in order to document features?