Handle errors on reload with the default uncaught exception handler #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code (added in jmxtrans#711) was throwing a RuntimeException, which I mistakenly believed would invoke the default uncaught exception handler. Instead, ThreadPoolExecutor swallows the RuntimeException and terminates the executor. Calling the default uncaught exception handler will currently just log the exception to stderr. Once jmxtrans#709 is merged, it will trigger our global uncaught exception handler, which logs the error and shuts down jmxtrans.
afn
force-pushed
the
handle-delayed-reload-errors
branch
from
c11354d
to
84f878b
Compare
|
Rebased. |
|
Why a separate PR from #709 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code (added in #711) was throwing a RuntimeException, which I mistakenly believed would invoke the default uncaught exception handler. Instead, ThreadPoolExecutor swallows the RuntimeException and terminates the executor.
Calling the default uncaught exception handler will currently just log the exception to stderr. Once #709 is merged, it will trigger our global uncaught exception handler, which logs the error and shuts down jmxtrans.