Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve empty lines between scss nested maps #1

Closed
wants to merge 1 commit into from

Conversation

jneander
Copy link
Owner

@jneander jneander commented Dec 1, 2022

Description

Empty lines between SCSS maps nested within other maps are not being preserved by prettier. This resolves that.

No issue was found for this particular bug. As a reference, it relates to prettier#12536, which mentioned the issue via code comment and in the pull request.

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

Empty lines between SCSS maps nested within other maps are not being
preserved by prettier. This resolves that.

No issue was found for this particular bug. As a reference, it relates
to prettier#12536, which mentioned the issue via code comment and in the pull
request.
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Size Change: +169 B (0%)

Total Size: 11.6 MB

Filename Size Change
./dist/esm/standalone.mjs 442 kB +34 B (0%)
./dist/index.js 1.42 MB +101 B (0%)
./dist/standalone.js 442 kB +34 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/bin-prettier.js 1.98 kB
./dist/cli.js 501 kB
./dist/doc.js 69.6 kB
./dist/esm 4.1 kB
./dist/esm/parser-angular.mjs 58.5 kB
./dist/esm/parser-babel.mjs 320 kB
./dist/esm/parser-espree.mjs 154 kB
./dist/esm/parser-flow.mjs 1.05 MB
./dist/esm/parser-glimmer.mjs 192 kB
./dist/esm/parser-graphql.mjs 42.8 kB
./dist/esm/parser-html.mjs 160 kB
./dist/esm/parser-markdown.mjs 168 kB
./dist/esm/parser-meriyah.mjs 162 kB
./dist/esm/parser-postcss.mjs 157 kB
./dist/esm/parser-typescript.mjs 1.47 MB
./dist/esm/parser-yaml.mjs 128 kB
./dist/LICENSE 294 kB
./dist/package.json 616 B
./dist/parser-angular.js 58.9 kB
./dist/parser-babel.js 321 kB
./dist/parser-espree.js 154 kB
./dist/parser-flow.js 1.05 MB
./dist/parser-glimmer.js 192 kB
./dist/parser-graphql.js 43.2 kB
./dist/parser-html.js 160 kB
./dist/parser-markdown.js 169 kB
./dist/parser-meriyah.js 162 kB
./dist/parser-postcss.js 157 kB
./dist/parser-typescript.js 1.47 MB
./dist/parser-yaml.js 129 kB
./dist/README.md 3.96 kB
./dist/third-party.js 303 kB

compressed-size-action

@jneander jneander closed this Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant