-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the possibility to use custom hash function #1130
base: main
Are you sure you want to change the base?
add the possibility to use custom hash function #1130
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1130 +/- ##
==========================================
+ Coverage 93.93% 94.30% +0.37%
==========================================
Files 47 47
Lines 6956 6958 +2
==========================================
+ Hits 6534 6562 +28
+ Misses 422 396 -26
Continue to review full report at Codecov.
|
5299bfc
to
cec48a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few formatting comments.
The change seems quite small so I would say it is okay but could you precise the use case you see for this change?
Most of the when I need to change the hashing, it is for some custom objects and I implement a custom __reduce__
which is sufficient to change the hash
behavior. I am curious of use cases that would not be handled by this.
I have a lot of custom objects and I can't implement |
f63c376
to
404c41d
Compare
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
404c41d
to
a7037e3
Compare
I have an alternate implementation in #1232 which I believe adheres more closely to how other custom 'plugin' type functionality works in Joblib. Examples being store backends and compressors. |
Add the possibility to use custom hash function