Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix numpy.dtype hashing for numpy >= 1.20 #1136

Merged
merged 21 commits into from
Dec 11, 2020
Merged

Fix numpy.dtype hashing for numpy >= 1.20 #1136

merged 21 commits into from
Dec 11, 2020

Commits on Dec 4, 2020

  1. short-circuit memoization when hashing dtypes 

    make a deepcopy of each dtype before hashing them in order to prevent
spurious pickle memoization that can introduce undesired inconcistency
in the hash value (created from a pickle string)
    @pierreglaser
    pierreglaser committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    3c5948a View commit details
    Browse the repository at this point in the history

  2. linting

    @pierreglaser
    pierreglaser committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    6222954 View commit details
    Browse the repository at this point in the history

  3. DOC add a note on joblib cache persistance

    @pierreglaser
    pierreglaser committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    39d7425 View commit details
    Browse the repository at this point in the history

  4. doc linting (?)

    @pierreglaser
    pierreglaser committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    054212b View commit details
    Browse the repository at this point in the history

  5. DOC phrasing

    @pierreglaser
    pierreglaser committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    7988d95 View commit details
    Browse the repository at this point in the history

  6. update changelog

    @pierreglaser
    pierreglaser committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    4189aba View commit details
    Browse the repository at this point in the history

  7. ci trigger

    @pierreglaser
    pierreglaser committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    0b1b31f View commit details
    Browse the repository at this point in the history

  8. typos/incorrect statements 

    Co-authored-by: Olivier Grisel <olivier.grisel@gmail.com>
    @pierreglaser @ogrisel
    pierreglaser and ogrisel committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    a7df810 View commit details
    Browse the repository at this point in the history

  9. PERF use separate pickle.dumps call for each dtype

    @pierreglaser
    pierreglaser committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    2dbaff6 View commit details
    Browse the repository at this point in the history

  10. compactify tests

    @pierreglaser
    pierreglaser committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    046fc79 View commit details
    Browse the repository at this point in the history

  11. properly shutdown computing ressources

    @pierreglaser
    pierreglaser committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    c45d0a4 View commit details
    Browse the repository at this point in the history

  12. DOC more rephrasing

    @pierreglaser
    pierreglaser committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    59b63f2 View commit details
    Browse the repository at this point in the history

  13. ensure 1-1 mapping between hash task and workers

    @pierreglaser
    pierreglaser committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    43ef2dd View commit details
    Browse the repository at this point in the history

  14. DOC, FIX rst formatting

    @pierreglaser
    pierreglaser committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    bbe6703 View commit details
    Browse the repository at this point in the history

  15. DOC more rephrasings

    @pierreglaser
    pierreglaser committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    dab6555 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. DOC, MNT weaken joblib.Memory stability contract

    @pierreglaser
    pierreglaser committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    5ddb54c View commit details
    Browse the repository at this point in the history

  2. TST, CLN clean up tests

    @pierreglaser
    pierreglaser committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    a5be753 View commit details
    Browse the repository at this point in the history

  3. DOC mention caching stability updates in CHANGES

    @pierreglaser
    pierreglaser committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    68b0be0 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. Apply suggestions from code review

    @ogrisel
    ogrisel committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    0c09155 View commit details
    Browse the repository at this point in the history

  2. CLN typos

    @pierreglaser
    pierreglaser committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    ec9968f View commit details
    Browse the repository at this point in the history

  3. CLN one (1) "that" is enough

    @pierreglaser
    pierreglaser committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    fc2b13b View commit details
    Browse the repository at this point in the history