Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not swallow PicklingError #1359

Merged
merged 11 commits into from
Feb 15, 2023
Merged

Do not swallow PicklingError #1359

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6bfd045
Do not swallow PicklingError
Nielius Nov 8, 2022
e7de461
Address PR comments
Nielius Nov 12, 2022
151a21e
Add test
Nielius Nov 12, 2022
2bfb3a7
Reformat to pass linting tests
Nielius Nov 12, 2022
6ade8e6
Add another test
Nielius Nov 12, 2022
0bcd263
Shorten long line
Nielius Nov 12, 2022
f62202b
formating + simplify tests + add new warning for easier filtering
jeremiedbb Feb 15, 2023
bd826a5
Merge remote-tracking branch 'upstream/master' into pr/Nielius/1359
jeremiedbb Feb 15, 2023
fc1fcb4
change log entry
jeremiedbb Feb 15, 2023
f605518
add version
jeremiedbb Feb 15, 2023
e4d1c2a
lint
jeremiedbb Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions joblib/_store_backends.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
"""Storage providers backends for Memory caching."""

from pickle import PicklingError
import re
import os
import os.path
Expand Down Expand Up @@ -189,6 +190,8 @@ def write_func(to_write, dest_filename):
compress=self.compress)

self._concurrency_safe_write(item, filename, write_func)
except PicklingError:
Nielius marked this conversation as resolved.
Show resolved Hide resolved
raise
except: # noqa: E722
" Race condition in the creation of the directory "

Expand Down