Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RELEASE joblib 1.3.1 - bugfix release - vendoring loky 3.4.1 for compatibility #1472

Merged
merged 3 commits into from Jun 29, 2023

Conversation

tomMoral
Copy link
Contributor

Fixes #1469 by vendoring loky3.4.1 which should be compatible with python 3.7

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (b9be27d) 94.82% compared to head (b502da5) 94.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1472      +/-   ##
==========================================
+ Coverage   94.82%   94.83%   +0.01%     
==========================================
  Files          45       45              
  Lines        7474     7474              
==========================================
+ Hits         7087     7088       +1     
+ Misses        387      386       -1     
Impacted Files Coverage Δ
joblib/__init__.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tomMoral tomMoral changed the title MTN vendor loky 3.4.1 RELEASE joblib 1.3.1 - bugfix release - vendoring loky 3.4.1 for compatibility Jun 29, 2023
@imatiach-msft
Copy link

@tomMoral will this also perchance fix the error I was seeing:

on windows python 3.7:

File "C:\Miniconda\envs\test\lib\site-packages\joblib\externals\loky\backend\popen_loky_win32.py", line 153, in main
_winapi.SYNCHRONIZE | _winapi.PROCESS_DUP_HANDLE, False, parent_pid
AttributeError: module '_winapi' has no attribute 'SYNCHRONIZE'

that was also an issue that appeared with python 3.7, windows platform and joblib 1.3.0 release.

@tomMoral
Copy link
Contributor Author

No, it will not.
Sorry I missed this point in the issue.

This is complicated as we did many changes in loky to support python3.10/11 as I think we had some bad interaction with handle sharing, due to the fact we were not using the SYNCHRONIZE key word. So I am not sure if we can mitigate this easily.
Could you please open an issue on loky with this problem reported? Maybe we can simply hard code the value of SYNCHRONIZE on 3.7 but we need to test this and as this is touchy code, it might take a little while.

In the meantime, as this PR already improve the compact support for other plateforms using 3.7, I will first release this.

@tomMoral tomMoral merged commit 476ff8e into joblib:master Jun 29, 2023
14 of 16 checks passed
@tomMoral tomMoral deleted the MTN_vendor_loky_3.4.1 branch June 29, 2023 15:14
@imatiach-msft
Copy link

@tomMoral thanks I've created a new issue here:
joblib/loky#411
as you suggested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.7 compatibility issue introduced by release 1.3.0
2 participants