FIX revert MemorizedFunc.call API change #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1576 +/- ##
==========================================
+ Coverage 95.16% 95.22% +0.05%
==========================================
Files 45 45
Lines 7674 7705 +31
==========================================
+ Hits 7303 7337 +34
+ Misses 371 368 -3 ☔ View full report in Codecov by Sentry. |
tomMoral
commented
May 2, 2024
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
May 11, 2024
https://build.opensuse.org/request/show/1172881 by user dirkmueller + dimstar_suse - update to 1.4.2: * Due to maintenance issues, 1.4.1 was not valid and we bumped the version to 1.4.2 * Fix a backward incompatible change in MemorizedFunc.call which needs to return the metadata. Also make sure that NotMemorizedFunc.call return an empty dict for metadata for consistency. joblib/joblib#1576
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
May 11, 2024
Release 1.4.2 -- 2024/05/02 Due to maintenance issues, 1.4.1 was not valid and we bumped the version to 1.4.2 - Fix a backward incompatible change in ``MemorizedFunc.call`` which needs to return the metadata. Also make sure that ``NotMemorizedFunc.call`` return an empty dict for metadata for consistency. joblib/joblib#1576
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.