Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add **kwargs to Profiler.print for renderers.ConsoleRenderer ? #301

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paugier
Copy link

@paugier paugier commented Apr 17, 2024

Thank you for pyinstrument, which is really nice, useful and easy to use!

In order to print percentages, I had to change a profiler.print() to

print(
    profiler.output(
        renderer=ConsoleRenderer(
            unicode=True,
            color=True,
            show_all=False,
            time="percent_of_total",
         )
    )
)

With these changes, I think it would have been enough to write profiler.print(time="percent_of_total").

This PR is to explain the situation and discuss what would be a good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant