Add **kwargs to Profiler.print for renderers.ConsoleRenderer ? #301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for pyinstrument, which is really nice, useful and easy to use!
In order to print percentages, I had to change a
profiler.print()
toWith these changes, I think it would have been enough to write
profiler.print(time="percent_of_total")
.This PR is to explain the situation and discuss what would be a good solution.