feat: extend eslint-config-typescript

john-d-pelingo · Dec 1, 2020 · 3bccd4b · 3bccd4b
1 parent aec2f7d
commit 3bccd4b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 30 deletions.
diff --git a/packages/eslint-config-typescript-react/.eslintrc.js b/packages/eslint-config-typescript-react/.eslintrc.js
@@ -7,38 +7,11 @@ const config = {
   parser: '@typescript-eslint/parser',
   plugins: ['@typescript-eslint', 'import', 'jsx-a11y', 'react-hooks'],
   extends: [
-    'eslint:recommended',
+    '@jdp-dev/eslint-config-typescript',
     'plugin:react/recommended',
-    'plugin:@typescript-eslint/eslint-recommended',
-    'plugin:@typescript-eslint/recommended',
-    'prettier',
     'prettier/react',
-    'prettier/@typescript-eslint',
-    'plugin:import/typescript',
   ],
   rules: {
-    '@typescript-eslint/explicit-function-return-type': 'off',
-    '@typescript-eslint/no-var-requires': 'off',
-    'import/no-default-export': 'error',
-    'import/no-deprecated': 'warn',
-    'import/order': [
-      'error',
-      {
-        pathGroupsExcludedImportTypes: ['builtin'],
-        groups: [
-          'builtin',
-          'external',
-          'internal',
-          'unknown',
-          'parent',
-          'sibling',
-          'index',
-        ],
-        'newlines-between': 'always',
-        alphabetize: { order: 'asc' },
-      },
-    ],
-    'import/prefer-default-export': 'off',
     'react-hooks/exhaustive-deps': 'warn',
     'react/prop-types': 'off',
     'react/react-in-jsx-scope': 'off',

diff --git a/packages/eslint-config-typescript-react/__tests__/validate-config.js b/packages/eslint-config-typescript-react/__tests__/validate-config.js
@@ -8,8 +8,13 @@ test('load config in eslint to validate all rule syntax is correct', (t) => {
   })
 
   const code = `
-  const Hello = ({ name }: { name: string }) => {
-    return <div>Hello, {name}!</div>
+  import { getName } from 'lib'
+
+  import { exclamationMark } from './const'
+
+  const Hello = ({ surname }: { surname: string }) => {
+    const fullName = \`\${getName()} + \${surname}\`
+    return <div>Hello, {fullName}{exclamationMark}</div>
   }
 `
 

diff --git a/packages/eslint-config-typescript-react/package.json b/packages/eslint-config-typescript-react/package.json
@@ -34,6 +34,7 @@
     "typescript": "^4.1.2"
   },
   "dependencies": {
+    "@jdp-dev/eslint-config-typescript": "^0.0.5",
     "@typescript-eslint/eslint-plugin": "^4.9.0",
     "@typescript-eslint/parser": "^4.9.0",
     "eslint": "^7.14.0",