feat: upgrade to eslint 8

package.json

@@ -30,13 +30,13 @@
     "test": "yarn workspaces run test"
   },
   "devDependencies": {
-    "@commitlint/cli": "^13.2.0",
-    "@commitlint/config-conventional": "^13.2.0",
-    "husky": "^7.0.2",
-    "lint-staged": "^11.1.2",
+    "@commitlint/cli": "^14.1.0",
+    "@commitlint/config-conventional": "^14.1.0",
+    "husky": "^7.0.4",
+    "lint-staged": "^11.2.6",
     "pinst": "^2.1.6",
     "prettier": "^2.4.1",
-    "standard-version": "^9.3.1",
+    "standard-version": "^9.3.2",
     "tape": "^5.3.1"
   }
 }

packages/eslint-config-typescript-react/.eslintrc.js

@@ -15,8 +15,23 @@ const config = {
     'plugin:import/typescript',
   ],
   rules: {
+    '@typescript-eslint/ban-ts-comment': [
+      'error',
+      {
+        'ts-expect-error': 'allow-with-description',
+        'ts-ignore': true,
+        'ts-nocheck': true,
+        'ts-check': false,
+      },
+    ],
+    '@typescript-eslint/consistent-type-imports': 'error',
     '@typescript-eslint/explicit-function-return-type': 'off',
+    '@typescript-eslint/no-unused-vars': [
+      'error',
+      { ignoreRestSiblings: true, argsIgnorePattern: '^_' },
+    ],
     '@typescript-eslint/no-var-requires': 'off',
+    '@typescript-eslint/prefer-optional-chain': 'error',
     'import/no-default-export': 'error',
     'import/no-deprecated': 'warn',
     'import/order': [

packages/eslint-config-typescript-react/__tests__/validate-config.js

@@ -1,25 +1,30 @@
 const eslint = require('eslint')
 const test = require('tape')
 
-test('load config in eslint to validate all rule syntax is correct', (t) => {
-  const cli = new eslint.CLIEngine({
+test('load config in eslint to validate all rule syntax is correct', async (t) => {
+  const cli = new eslint.ESLint({
     useEslintrc: false,
-    configFile: 'index.js',
+    overrideConfigFile: 'index.js',
   })
 
   const code = `
   import { getName } from 'lib'
 
   import { exclamationMark } from './const'
 
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   const Hello = ({ surname }: { surname: string }) => {
     const fullName = \`\${getName()} + \${surname}\`
     return <div>Hello, {fullName}{exclamationMark}</div>
   }
 `
 
-  const result = cli.executeOnText(code)
+  const result = await cli.lintText(code)
 
-  t.equal(result.errorCount, 0)
+  const errorCount = result.reduce((acc, r) => {
+    return acc + r.errorCount
+  }, 0)
+
+  t.equal(errorCount, 0)
   t.end()
 })

packages/eslint-config-typescript-react/package.json

@@ -30,26 +30,26 @@
     "test": "tape __tests__/*.js"
   },
   "peerDependencies": {
-    "@typescript-eslint/eslint-plugin": ">= 4",
-    "eslint": ">= 7",
+    "@typescript-eslint/eslint-plugin": ">= 5",
+    "eslint": ">= 8",
     "eslint-plugin-import": ">= 2",
-    "eslint-plugin-jsx-a11y": ">= 6",
+    "eslint-plugin-jsx-a11y": ">= 7",
     "eslint-plugin-react": ">= 7",
     "eslint-plugin-react-hooks": ">= 4",
     "react": ">= 17",
-    "typescript": ">= 4.1"
+    "typescript": ">= 4.4.4"
   },
   "dependencies": {
-    "@typescript-eslint/eslint-plugin": "^4.32.0",
-    "@typescript-eslint/parser": "^4.32.0",
-    "eslint": "^7.32.0",
+    "@typescript-eslint/eslint-plugin": "^5.3.0",
+    "@typescript-eslint/parser": "^5.3.0",
+    "eslint": "^8.2.0",
     "eslint-config-prettier": "^8.3.0",
-    "eslint-plugin-import": "^2.24.2",
+    "eslint-plugin-import": "^2.25.2",
     "eslint-plugin-jsx-a11y": "^6.4.1",
-    "eslint-plugin-react": "^7.25.1",
+    "eslint-plugin-react": "^7.26.1",
     "eslint-plugin-react-hooks": "^4.2.0",
     "react": "^17.0.2",
-    "typescript": "^4.4.3"
+    "typescript": "^4.4.4"
   },
   "devDependencies": {
     "tape": "^5.3.1"

packages/eslint-config-typescript/.eslintrc.js

@@ -31,7 +31,6 @@ const config = {
     ],
     '@typescript-eslint/no-var-requires': 'off',
     '@typescript-eslint/prefer-optional-chain': 'error',
-    '@typescript-eslint/prefer-nullish-coalescing': 'error',
     'import/no-default-export': 'error',
     'import/no-deprecated': 'warn',
     'import/order': [

packages/eslint-config-typescript/__tests__/validate-config.js

@@ -1,10 +1,10 @@
 const eslint = require('eslint')
 const test = require('tape')
 
-test('load config in eslint to validate all rule syntax is correct', (t) => {
-  const cli = new eslint.CLIEngine({
+test('load config in eslint to validate all rule syntax is correct', async (t) => {
+  const cli = new eslint.ESLint({
     useEslintrc: false,
-    configFile: 'index.js',
+    overrideConfigFile: 'index.js',
   })
 
   const code = `
@@ -16,10 +16,16 @@ test('load config in eslint to validate all rule syntax is correct', (t) => {
     const name = getName()
     console.log(\`Hello, \${name}\${exclamationMark}\`)
   }
+
+  greet()
 `
 
-  const result = cli.executeOnText(code)
+  const result = await cli.lintText(code)
+
+  const errorCount = result.reduce((acc, r) => {
+    return acc + r.errorCount
+  }, 0)
 
-  t.equal(result.errorCount, 0)
+  t.equal(errorCount, 0)
   t.end()
 })

packages/eslint-config-typescript/package.json

@@ -30,18 +30,18 @@
     "test": "tape __tests__/*.js"
   },
   "peerDependencies": {
-    "@typescript-eslint/eslint-plugin": ">= 4",
-    "eslint": ">= 7",
+    "@typescript-eslint/eslint-plugin": ">= 5",
+    "eslint": ">= 8",
     "eslint-plugin-import": ">= 2",
-    "typescript": ">= 4.1"
+    "typescript": ">= 4.4.4"
   },
   "dependencies": {
-    "@typescript-eslint/eslint-plugin": "^4.32.0",
-    "@typescript-eslint/parser": "^4.32.0",
-    "eslint": "^7.32.0",
+    "@typescript-eslint/eslint-plugin": "^5.3.0",
+    "@typescript-eslint/parser": "^5.3.0",
+    "eslint": "^8.2.0",
     "eslint-config-prettier": "^8.3.0",
-    "eslint-plugin-import": "^2.24.2",
-    "typescript": "^4.4.3"
+    "eslint-plugin-import": "^2.25.2",
+    "typescript": "^4.4.4"
   },
   "devDependencies": {
     "tape": "^5.3.1"

packages/eslint-config/__tests__/validate-config.js

@@ -2,9 +2,9 @@ const eslint = require('eslint')
 const test = require('tape')
 
 test('load config in eslint to validate all rule syntax is correct', (t) => {
-  const cli = new eslint.CLIEngine({
+  const cli = new eslint.ESLint({
     useEslintrc: false,
-    configFile: 'index.js',
+    overrideConfigFile: 'index.js',
   })
 
   const code = `
@@ -20,8 +20,12 @@ test('load config in eslint to validate all rule syntax is correct', (t) => {
   greet()
 `
 
-  const result = cli.executeOnText(code)
+  cli.lintText(code).then((result) => {
+    const errorCount = result.reduce((acc, r) => {
+      return acc + r.errorCount
+    }, 0)
 
-  t.equal(result.errorCount, 0)
-  t.end()
+    t.equal(errorCount, 0)
+    t.end()
+  })
 })

packages/eslint-config/package.json

@@ -30,13 +30,13 @@
     "test": "tape __tests__/*.js"
   },
   "peerDependencies": {
-    "eslint": ">= 7",
+    "eslint": ">= 8",
     "eslint-plugin-import": ">= 2"
   },
   "dependencies": {
-    "eslint": "^7.32.0",
+    "eslint": "^8.2.0",
     "eslint-config-prettier": "^8.3.0",
-    "eslint-plugin-import": "^2.24.2"
+    "eslint-plugin-import": "^2.25.2"
   },
   "devDependencies": {
     "tape": "^5.3.1"

packages/prettier-config/package.json

@@ -28,7 +28,7 @@
     "test": "tape __tests__/*.js"
   },
   "peerDependencies": {
-    "prettier": "^2.2.1"
+    "prettier": "^2.4.1"
   },
   "devDependencies": {
     "tape": "^5.3.1"

packages/tsconfig/package.json

@@ -27,7 +27,7 @@
     "test": "tape __tests__/*.js"
   },
   "peerDependencies": {
-    "typescript": ">= 4.1"
+    "typescript": ">= 4.4.4"
   },
   "devDependencies": {
     "tape": "^5.3.1"