feat: do not extend eslint-config

john-d-pelingo · Dec 2, 2020 · cebe150 · cebe150
1 parent 18fc7ec
commit cebe150
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 11 deletions.
diff --git a/packages/eslint-config-typescript/.eslintrc.js b/packages/eslint-config-typescript/.eslintrc.js
@@ -7,15 +7,36 @@ const config = {
   parser: '@typescript-eslint/parser',
   plugins: ['@typescript-eslint', 'import', 'jsx-a11y'],
   extends: [
-    '@jdp-dev/eslint-config',
+    'eslint:recommended',
     'plugin:@typescript-eslint/eslint-recommended',
     'plugin:@typescript-eslint/recommended',
+    'prettier',
     'prettier/@typescript-eslint',
     'plugin:import/typescript',
   ],
   rules: {
     '@typescript-eslint/explicit-function-return-type': 'off',
     '@typescript-eslint/no-var-requires': 'off',
+    'import/no-default-export': 'error',
+    'import/no-deprecated': 'warn',
+    'import/order': [
+      'error',
+      {
+        pathGroupsExcludedImportTypes: ['builtin'],
+        groups: [
+          'builtin',
+          'external',
+          'internal',
+          'unknown',
+          'parent',
+          'sibling',
+          'index',
+        ],
+        'newlines-between': 'always',
+        alphabetize: { order: 'asc' },
+      },
+    ],
+    'import/prefer-default-export': 'off',
   },
   settings: {
     'import/ignore': ['node_modules'],

diff --git a/packages/eslint-config-typescript/package.json b/packages/eslint-config-typescript/package.json
@@ -37,7 +37,6 @@
     "typescript": "^4.1.2"
   },
   "dependencies": {
-    "@jdp-dev/eslint-config": "^0.0.5",
     "@typescript-eslint/eslint-plugin": "^4.9.0",
     "@typescript-eslint/parser": "^4.9.0",
     "eslint": "^7.14.0",

diff --git a/yarn.lock b/yarn.lock
@@ -190,15 +190,6 @@
     minimatch "^3.0.4"
     strip-json-comments "^3.1.1"
 
-"@jdp-dev/eslint-config@^0.0.5":
-  version "0.0.5"
-  resolved "https://registry.yarnpkg.com/@jdp-dev/eslint-config/-/eslint-config-0.0.5.tgz#25a05d3b1bc57ad0a6e38ef6afbf1cca121dedeb"
-  integrity sha512-dnldoW9drJmhYux04hH3ClbKlPs+U23kY6c4MczgHc4oq+15Q+Bnnp0HUioWKPkhKq1l+3QCCJQTM+4OUImi+A==
-  dependencies:
-    eslint "^7.14.0"
-    eslint-config-prettier "^6.15.0"
-    eslint-plugin-import "^2.22.1"
-
 "@nodelib/fs.scandir@2.1.3":
   version "2.1.3"
   resolved "https://registry.yarnpkg.com/@nodelib/fs.scandir/-/fs.scandir-2.1.3.tgz#3a582bdb53804c6ba6d146579c46e52130cf4a3b"