Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate release process #325

Merged
merged 84 commits into from
Mar 15, 2024
Merged
Show file tree
Hide file tree
Changes from 76 commits
Commits
Show all changes
84 commits
Select commit Hold shift + click to select a range
c645011
Draft release functions
ekcorso Nov 20, 2023
9803abc
Add build verification part b
ekcorso Nov 20, 2023
89bd0fa
Add pause for manual build verification
ekcorso Nov 24, 2023
c615013
Bring in tested release script from the other repo
ekcorso Jan 30, 2024
ea3c1f6
Fix references to dist folder location
ekcorso Feb 11, 2024
e5972cb
Create release notes
ekcorso Feb 17, 2024
27d5d5e
Revise regexs + minor linting
ekcorso Feb 17, 2024
9ed8ebb
Create github release draft
ekcorso Feb 19, 2024
f2e334c
Refactor build verification logic
ekcorso Feb 19, 2024
083b827
Update tag push logic, remove exit
ekcorso Feb 20, 2024
7abfb1a
Refactor release draft url check
ekcorso Feb 22, 2024
728382f
Clean up style and improve logging
ekcorso Feb 22, 2024
6417210
Add check for test release
ekcorso Feb 23, 2024
ecc3767
List dependencies for release
john-kurkowski Feb 26, 2024
4621470
Check scripts
john-kurkowski Feb 26, 2024
e88e423
Move basic setup (input) inside main
ekcorso Feb 27, 2024
bac1248
Refactor releasing to pypi
ekcorso Feb 27, 2024
a5824fa
Merge remote-tracking branch 'upstream/master' into add-release-script
john-kurkowski Feb 27, 2024
6fce0f1
Add docstring
ekcorso Feb 27, 2024
0c9bd7e
Remove unused import
ekcorso Feb 27, 2024
97334ad
Sort imports
ekcorso Feb 27, 2024
be3c801
Rename ambiguous dir variable
ekcorso Feb 27, 2024
27c9048
Remove unecessary params from open()
ekcorso Feb 27, 2024
d74891f
Remove unnecessary try/ except blocks
ekcorso Mar 4, 2024
d3ecd31
Streamline logging
ekcorso Mar 5, 2024
82cf56f
Fix regex and update it's documentation
ekcorso Mar 5, 2024
885a46b
Fix type errors
ekcorso Mar 6, 2024
b17d244
Parameterize use of version number (remove global)
ekcorso Mar 6, 2024
720c5af
Merge remote-tracking branch 'upstream/master' into add-release-script
john-kurkowski Mar 6, 2024
1496107
Parameterize is_test
ekcorso Mar 7, 2024
29c618a
Pass GITHUB_TOKEN in as parameter
ekcorso Mar 7, 2024
56659e6
Use pathlib for dist paths throughout
ekcorso Mar 8, 2024
3590279
Dedupe twine test/ reg upload logic
ekcorso Mar 8, 2024
a0b8e5c
Use requests lib instead of curl
ekcorso Mar 9, 2024
3dd1fbe
Fix lint errors
ekcorso Mar 9, 2024
dc40d6f
Add type annotation for upload command
ekcorso Mar 9, 2024
4d375f0
Allow newer syntax on older Python
john-kurkowski Mar 9, 2024
f060e86
Scaffold test for release script
john-kurkowski Mar 11, 2024
c74da79
Allow typechecking non-package code
john-kurkowski Mar 11, 2024
af9b799
Simplify upload to Pypi
ekcorso Mar 11, 2024
d089ba7
Remove comments
ekcorso Mar 11, 2024
1a42543
Refactor error handling for requests
ekcorso Mar 11, 2024
d9d0e5a
Refactor imput validation for is_test check
ekcorso Mar 11, 2024
a4fb608
Merge branch 'add-release-script' into test-release-script
john-kurkowski Mar 12, 2024
7f64e21
Reduce calls
john-kurkowski Mar 12, 2024
25f03a4
Prefer f-strings to concatenation
john-kurkowski Mar 12, 2024
d6f177c
Document prerequisites
ekcorso Mar 12, 2024
8535304
Cleanup main and extract env setup checks to helpers
ekcorso Mar 12, 2024
1b74692
Test release script happy path
john-kurkowski Mar 12, 2024
502f357
Merge branch 'add-release-script' into test-release-script
john-kurkowski Mar 12, 2024
e1be439
Check if version tag already exists
ekcorso Mar 12, 2024
a231fe1
Simplify
john-kurkowski Mar 12, 2024
d7f63dc
Merge branch 'add-release-script' into test-release-script
john-kurkowski Mar 12, 2024
3d99f1c
Revert "Check if version tag already exists"
ekcorso Mar 12, 2024
72141cd
Replace test repo url
ekcorso Mar 12, 2024
32b4c9a
Expect Windows snapshot test to fail
john-kurkowski Mar 12, 2024
978913b
fixup! Expect Windows snapshot test to fail
john-kurkowski Mar 13, 2024
aa29a97
Merge pull request #1 from ekcorso/add-release-script
ekcorso Mar 13, 2024
83e706b
Revert "Check if version tag already exists"
ekcorso Mar 12, 2024
dbb2bd1
Replace test repo url
ekcorso Mar 12, 2024
939e9ba
Update snapshot
ekcorso Mar 13, 2024
d6a3946
Merge pull request #2 from ekcorso/test-release-script
ekcorso Mar 15, 2024
ac81f79
Merge remote-tracking branch 'remote_fork/master'
ekcorso Mar 15, 2024
6454199
Scaffold test for release script
john-kurkowski Mar 11, 2024
bbd4e6d
Allow typechecking non-package code
john-kurkowski Mar 11, 2024
99ac9ef
Reduce calls
john-kurkowski Mar 12, 2024
8bc06ee
Prefer f-strings to concatenation
john-kurkowski Mar 12, 2024
78baee7
Test release script happy path
john-kurkowski Mar 12, 2024
7bd161d
Simplify
john-kurkowski Mar 12, 2024
4153e83
Expect Windows snapshot test to fail
john-kurkowski Mar 12, 2024
aa22335
fixup! Expect Windows snapshot test to fail
john-kurkowski Mar 13, 2024
ffea698
Update snapshot
ekcorso Mar 13, 2024
5492d66
Temp commit for test
ekcorso Mar 15, 2024
a80899c
Merge remote-tracking branch 'origin/add-release-script'
ekcorso Mar 15, 2024
d8601ff
Revert "Temp commit for test"
ekcorso Mar 15, 2024
10424f6
Update snapshot
john-kurkowski Mar 15, 2024
f14f8e7
Document
john-kurkowski Mar 15, 2024
9c7bce9
Update pre req documentation
ekcorso Mar 15, 2024
7ed31c1
Snapshot all mock calls
john-kurkowski Mar 15, 2024
19e7b5b
DRY
john-kurkowski Mar 15, 2024
a8ae3bf
Fix missing `tar` test
john-kurkowski Mar 15, 2024
7f5936c
fixup! DRY
john-kurkowski Mar 15, 2024
9f6a530
Unskip tests on Windows
john-kurkowski Mar 15, 2024
e9d64d6
Revert "Unskip tests on Windows"
john-kurkowski Mar 15, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ dependencies = [
]

[project.optional-dependencies]
release = [
"build",
"twine",
]
testing = [
"black",
"mypy",
Expand All @@ -49,6 +53,7 @@ testing = [
"pytest-mock",
"responses",
"ruff",
"syrupy",
"tox",
"types-filelock",
"types-requests",
Expand Down Expand Up @@ -79,6 +84,7 @@ write_to = "tldextract/_version.py"
version = {attr = "setuptools_scm.get_version"}

[tool.mypy]
explicit_package_bases = true
strict = true

[tool.pytest.ini_options]
Expand Down
231 changes: 231 additions & 0 deletions scripts/release.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,231 @@
"""
This script automates the release process for a Python package.

It will:
- Add a git tag for the given version.
- Remove the previous dist folder.
- Create a build.
- Ask the user to verify the build.
- Upload the build to PyPI.
- Push all git tags to the remote.
- Create a draft release on GitHub using the version notes in CHANGELOG.md.

Prerequisites:
- This must be run from the root of the repository.
- The repo must have a clean git working tree.
- The user must have the GITHUB_TOKEN environment variable set to a valid GitHub personal access token.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a bullet for PyPI credentials? During the script, users will need to paste in a token from their password manager?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. Done!

- The CHANGELOG.md file must already contain an entry for the version being released.
- Install requirements with: pip install --upgrade --editable '.[release]'

"""

from __future__ import annotations

import os
import re
import subprocess
import sys
from pathlib import Path

import requests


def add_git_tag_for_version(version: str) -> None:
"""Add a git tag for the given version."""
subprocess.run(["git", "tag", "-a", version, "-m", version], check=True)
print(f"Version {version} tag added successfully.")


def remove_previous_dist() -> None:
"""Check for dist folder, and if it exists, remove it."""
subprocess.run(["rm", "-rf", Path("dist")], check=True)
print("Previous dist folder removed successfully.")


def create_build() -> None:
"""Create a build."""
subprocess.run(["python", "-m", "build"], check=True)
print("Build created successfully.")


def verify_build(is_test: str) -> None:
"""Verify the build."""
build_files = os.listdir("dist")
if len(build_files) != 2:
print(
"WARNING: dist folder contains incorrect number of files.", file=sys.stderr
)
print("Contents of dist folder:")
subprocess.run(["ls", "-l", Path("dist")], check=True)
print("Contents of tar files in dist folder:")
for build_file in build_files:
subprocess.run(["tar", "tvf", Path("dist") / build_file], check=True)
confirmation = input("Does the build look correct? (y/n): ")
if confirmation == "y":
print("Build verified successfully.")
upload_build_to_pypi(is_test)
push_git_tags()
else:
raise Exception("Could not verify. Build was not uploaded.")


def generate_github_release_notes_body(token: str, version: str) -> str:
"""Generate and grab release notes URL from Github."""
response = requests.post(
"https://api.github.com/repos/john-kurkowski/tldextract/releases/generate-notes",
headers={
"Accept": "application/vnd.github+json",
"Authorization": f"Bearer {token}",
"X-GitHub-Api-Version": "2022-11-28",
},
json={"tag_name": version},
)

try:
response.raise_for_status()
except requests.exceptions.HTTPError as err:
print(
f"WARNING: Failed to generate release notes from Github: {err}",
file=sys.stderr,
)
return ""
return str(response.json()["body"])


def get_release_notes_url(body: str) -> str:
"""Parse the release notes content to get the changelog URL."""
url_pattern = re.compile(r"\*\*Full Changelog\*\*: (.*)$")
match = url_pattern.search(body)
if match:
return match.group(1)
else:
print(
"WARNING: Failed to parse release notes URL from GitHub response.",
file=sys.stderr,
)
return ""


def get_changelog_release_notes(release_notes_url: str, version: str) -> str:
"""Get the changelog release notes.

Uses a regex starting on a heading beginning with the version number literal, and matching until the next heading. Using regex to match markup is brittle. Consider a Markdown-parsing library instead.
"""
with open("CHANGELOG.md") as file:
changelog_text = file.read()
pattern = re.compile(rf"## {re.escape(version)}[^\n]*(.*?)## ", re.DOTALL)
match = pattern.search(changelog_text)
if match:
return str(match.group(1)).strip()
else:
print(
f"WARNING: Failed to parse changelog release notes. Manually copy this version's notes from the CHANGELOG.md file to {release_notes_url}.",
file=sys.stderr,
)
return ""


def create_release_notes_body(token: str, version: str) -> str:
"""Compile the release notes."""
github_release_body = generate_github_release_notes_body(token, version)
release_notes_url = get_release_notes_url(github_release_body)
changelog_notes = get_changelog_release_notes(release_notes_url, version)
full_release_notes = f"{changelog_notes}\n\n**Full Changelog**: {release_notes_url}"
return full_release_notes


def create_github_release_draft(token: str, version: str) -> None:
"""Create a release on GitHub."""
release_body = create_release_notes_body(token, version)
response = requests.post(
"https://api.github.com/repos/john-kurkowski/tldextract/releases",
headers={
"Accept": "application/vnd.github+json",
"Authorization": f"Bearer {token}",
"X-GitHub-Api-Version": "2022-11-28",
},
json={
"tag_name": version,
"name": version,
"body": release_body,
"draft": True,
"prerelease": False,
},
)

try:
response.raise_for_status()
except requests.exceptions.HTTPError as err:
print(
f"WARNING: Failed to create release on Github: {err}",
file=sys.stderr,
)
return
print(f'Release created successfully: {response.json()["html_url"]}')


def upload_build_to_pypi(is_test: str) -> None:
"""Upload the build to PyPI."""
repository: list[str | Path] = (
[] if is_test == "n" else ["--repository", "testpypi"]
)
upload_command = ["twine", "upload", *repository, Path("dist") / "*"]
subprocess.run(
upload_command,
check=True,
)


def push_git_tags() -> None:
"""Push all git tags to the remote."""
subprocess.run(["git", "push", "--tags", "origin", "master"], check=True)


def check_for_clean_working_tree() -> None:
"""Check for a clean git working tree."""
git_status = subprocess.run(
["git", "status", "--porcelain"], capture_output=True, text=True
)
if git_status.stdout:
print(
"Git working tree is not clean. Please commit or stash changes.",
file=sys.stderr,
)
sys.exit(1)


def get_env_github_token() -> str:
"""Check for the GITHUB_TOKEN environment variable."""
github_token = os.environ.get("GITHUB_TOKEN")
if not github_token:
print("GITHUB_TOKEN environment variable not set.", file=sys.stderr)
sys.exit(1)
return github_token


def get_is_test_response() -> str:
"""Ask the user if this is a test release."""
while True:
is_test = input("Is this a test release? (y/n): ")
if is_test in ["y", "n"]:
return is_test
else:
print("Invalid input. Please enter 'y' or 'n.'")


def main() -> None:
"""Run the main program."""
check_for_clean_working_tree()
github_token = get_env_github_token()
is_test = get_is_test_response()
version_number = input("Enter the version number: ")

add_git_tag_for_version(version_number)
remove_previous_dist()
create_build()
verify_build(is_test)
create_github_release_draft(github_token, version_number)


if __name__ == "__main__":
main()