New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to handle graphql v16_x breaking changes #495
Merged
bueche
merged 16 commits into
join-monster:master
from
bueche:feat/support_for_graphqlv16_6_0
Jun 23, 2023
Merged
update to handle graphql v16_x breaking changes #495
bueche
merged 16 commits into
join-monster:master
from
bueche:feat/support_for_graphqlv16_6_0
Jun 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bueche
changed the title
initial commit to fix issues with graphsql v16_x breaking changes
update to handle graphsql v16_x breaking changes
Jun 1, 2023
bueche
changed the title
update to handle graphsql v16_x breaking changes
update to handle graphql v16_x breaking changes
Jun 1, 2023
lorensr
reviewed
Jun 4, 2023
lorensr
reviewed
Jun 18, 2023
…bueche/join-monster into feat/support_for_graphqlv16_6_0
…l PRs for a 3.2.0 release
This was referenced Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to upgrade join-monster to support graphql@16_6_0. There were a number of breaking changes introduced in graphql version 16 that had a major impact (mostly) to the tests and to some of the code in join-monster. This PR fixes these changes so the tests pass. I can't guarantee that other breaking changes were not caught by the tests.
Some of the breaking fixes of graphql v16:
lodash partial
. I just removed that dependency and fixed the parameters so that they would align with the v16 approach. So for example:was changed to:
Fragment tests failed due to a change in structure. I couldn't find the PR in graphql that impacted this one but the changes were mostly the main join-master index.js. Without these changes a number of the relay tests failed with the following error:
def.args is not iterable
and some code in graphql was added to iterate through this structure which in most cases was an array (only the failed cases were not an array). So I changed this definition to be an array (seesrc/index.js
change.Other fragment tests failed with
Support for returning GraphQLObjectType from resolveType was removed in graphql-js@16.0.0 please return type name instead
and this was fixed also insrc/index.js
to addname
totype
.An error occurred:
TypeError: Class constructor GraphQLNonNull cannot be invoked without 'new'
that was fixed as well.Testing
To test this change it is necessary (still) to use node v14 (
nvm use 14
).It is important to ensure that
graphql@16_6_0
is installed.I ran the following suites:
npm run testsqlite3
npm run testpg
npm run testpg-paging
(postgres)npm run testmysql
andnpm run testmysql-paging
(mysql)all passed, except for the offset cursor tests in mysql which were throwing an error
This type of pagination not supported on this dialect
which is a join-monster error and I believe expected.Checklist