Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui(orderbook): add delay hint to highlighted offer toggle #735

Merged
merged 4 commits into from
May 14, 2024

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Mar 29, 2024

Adds a small hint that it might take some time for an offer to appear in the local order book, e.g. when the maker has just been started recently. This hint will disappear if the current nickname is present in the offer list.

Edit: Screenshots outdated - see below 🙏

📸

Before

After

@theborakompanioni theborakompanioni self-assigned this Mar 29, 2024
@theborakompanioni theborakompanioni added enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience labels Mar 29, 2024
@theborakompanioni theborakompanioni marked this pull request as ready for review March 30, 2024 08:54
@editwentyone
Copy link

can you pull the view on toggle down to the green highlighted row? people would understand faster

@theborakompanioni
Copy link
Collaborator Author

can you pull the view on toggle down to the green highlighted row? people would understand faster

I am sorry, I do not understand what you mean exactly. Can you please explain this in more detail?

@editwentyone
Copy link

sure, sorry.

  • on toggle on the hightlight
  • the user is automatically scrolled or moved to the right page
  • and the user sees its own green highlighted offer

is this possible?

@theborakompanioni
Copy link
Collaborator Author

theborakompanioni commented Mar 31, 2024

sure, sorry.

* on toggle on the hightlight

* the user is automatically scrolled or moved to the right page

* and the user sees its own green highlighted offer

is this possible?

Ah, thanks for clarifying.

Of course that would be possible. However, isn't it kind of unexpected to scroll down on click on a toggle?
What about showing a users offer separately, e.g. above the table, in addition to highlighting the table row?

@theborakompanioni
Copy link
Collaborator Author

theborakompanioni commented Apr 2, 2024

Notes from discussion:

  • Orderbook should get a sticky header
  • Toggle is disabled till the users order in the local orderbook
  • On toggle, pagination is set to "display all" and offer should scroll into view

@theborakompanioni theborakompanioni marked this pull request as draft April 2, 2024 16:36
@theborakompanioni
Copy link
Collaborator Author

Notes from discussion:

* [ ]  Orderbook should get a sticky header

* [ ]  Toggle is disabled till the users order in the local orderbook

* [ ]  On toggle, pagination is set to "display all" and offer should scroll into view

Thought about this some more.

  1. Sticky header is difficult, as the table would need a min-height. Does not look nice. ❌
  2. Disable toggle till the offer is in the list: Done ✅
  3. Scrolling to the offer while setting pagination to "display all" feels confusing

What feels like a good solution to point #3 is:
Ability to pin the offer to the top of the list.
It seems to be the easiest and achieves what should be done: Being able to compare ones own offer to other offers.

📸

Offer absent (toggle disabled + subtitle hint)

Offer present

Offer present, highlighted

Offer present, pinned to top

What do you think @editwentyone ?

@theborakompanioni theborakompanioni marked this pull request as ready for review May 8, 2024 18:35
@editwentyone
Copy link

@theborakompanioni i'm fine with the changes :) you can merge

@theborakompanioni theborakompanioni merged commit 9d2aaa6 into master May 14, 2024
3 checks passed
@theborakompanioni theborakompanioni deleted the ui/offer-delay-hint branch May 14, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants