Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add X (twitter) icon to footer and update sprite.svg file #753

Closed
wants to merge 2 commits into from

Conversation

KellyKiiru
Copy link

No description provided.

@KellyKiiru KellyKiiru changed the title Add X (twitter) icon and update sprite.svg file Add X (twitter) icon to footer and update sprite.svg file May 7, 2024
@@ -137,6 +137,14 @@ export default function Footer() {
>
<Sprite symbol="telegram" width="18px" height="18px" />
</a>
<a
href="https://x.com/joinmarket"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK, this account is controlled by Chris Belcher, so is basically dead currently.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh alright. Mind directing me to the right account?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't one for JoinMarket currently.

But guess Jam could have one? @theborakompanioni ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No! Removing all links to walled garden platforms is what should be done 😉
#750

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaah shaks! haha I was so happy when I made the changes. Anyway, I noticed that the footer was alright and doesn't have any twitter links. We can close this issue.

Lemme go through the issues tab and see what else I can take on

Logo

@theborakompanioni
Copy link
Collaborator

theborakompanioni commented May 8, 2024

Thanks for the effort @KellyKiiru!
As mentioned in #750, removing the links (and icons) altogether would be great.
Could be done in this PR if you want. What do you think?

@theborakompanioni
Copy link
Collaborator

@KellyKiiru Are you still working on this? 🙏

@KellyKiiru
Copy link
Author

Hey @theborakompanioni. No.

@theborakompanioni
Copy link
Collaborator

Hey @theborakompanioni. No.

Thanks for the quick reply! Closing the PR now!
Please feel free to pick it up again (or any other issue that you feel suitable)!
Thank you 🧡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants