Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update dependencies #757

Merged
merged 7 commits into from
May 17, 2024
Merged

build(deps): update dependencies #757

merged 7 commits into from
May 17, 2024

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented May 15, 2024

Updates following dependencies:

     @types/react      ^18.2.47  →  ^18.3.2
     @types/react-dom  ^18.2.18  →  ^18.3.0
     react             ^18.2.0  →  ^18.3.1
     react-dom         ^18.2.0  →  ^18.3.1
     @emotion/react    ^11.11.3  →  ^11.11.4
     bootstrap         ^5.3.2  →    ^5.3.3
     react-router-dom  ^6.21.1  →    ^6.23.1
     @testing-library/jest-dom    ^6.2.0  →    ^6.4.5
     @testing-library/react      ^14.1.2  →   ^15.0.7
     @types/jest                ^29.5.11  →  ^29.5.12
     prettier  ^3.1.1  →  ^3.2.5
  • Update node in github actions from v16 to v20.

How to test

After checking out and pulling the branch, run npm install and verify that everything is still working as expected.
Run visual tests with npm run dev:start and npm start.
Also test with CI=true npm test and build with npm run build.

 @testing-library/jest-dom    ^6.2.0  →    ^6.4.5
 @testing-library/react      ^14.1.2  →   ^15.0.7
 @types/jest                ^29.5.11  →  ^29.5.12
 @types/react      ^18.2.47  →  ^18.3.2
 @types/react-dom  ^18.2.18  →  ^18.3.0
 react             ^18.2.0  →  ^18.3.1
 react-dom         ^18.2.0  →  ^18.3.1
@theborakompanioni theborakompanioni added the dependencies Pull requests that update a dependency file label May 15, 2024
@theborakompanioni theborakompanioni self-assigned this May 15, 2024
@theborakompanioni theborakompanioni marked this pull request as ready for review May 16, 2024 07:13
Copy link
Contributor

@barrytra barrytra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With node v20 everything runs perfect.
visual tests checked:
Screenshot from 2024-05-17 10-34-34

other tests are also approved:
Screenshot from 2024-05-17 10-26-43

and project was built successfully.

@0xSaksham
Copy link

It works and the production build is also completed successfully.

@0xSaksham 0xSaksham merged commit 82f2ae7 into master May 17, 2024
3 checks passed
@0xSaksham 0xSaksham deleted the deps branch May 17, 2024 12:49
0xSaksham added a commit that referenced this pull request May 17, 2024
Copy link

@amitx13 amitx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the changes and verified that everything works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants