feat: m2m change detection follow up #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 19, 2024 12:24
… to be called after the hook cycles is evaluated, so we get the changes on m2m relations for every hook
Grandlouis
changed the title
added 2 commits
April 22, 2024 09:40
stephenh
reviewed
Apr 22, 2024
There was a problem hiding this comment.
Hey @Grandlouis ; thanks for the PR! I'd like to try using a JoinRow.op flag instead and see how that works; it will be similar to how InstanceData.op works, which I think will be nice for clarity, and also probably help us eventually implementing the "use changes to get both old value + new value".
…cle, updating driver to use it, exposing reset function
stephenh
approved these changes
May 19, 2024
stephenh
pushed a commit
that referenced
this pull request
May 19, 2024
# [1.168.0](v1.167.0...v1.168.0) (2024-05-19) ### Features * m2m change detection follow up ([#1046](#1046)) ([ed4be3d](ed4be3d))
|
🎉 This PR is included in version 1.168.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to satisfy this ticket -> #1044
Update: I was only able to delay the "reset"/"update" of the m2m rows untilafterCommitso all hooks get access to the m2m relation changes on thechanges.fieldsproxyUpdate 2: Now the
JoinRowhas anopfields that indicates the state it has on the flush cycle, whether it is pending, flushed or completed. We use this flags to indicate if there are changes on the m2m relations.Support for o2m, o2o and old value still pending 😅