fix: Fix transformed properties assigned to incorrect entities. #1064
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we lazy-initialized properties, i.e. like:
I'd forgotten that internally
hasAsyncProperty
& friends using thecurrentlyInstantiatingEntity
to know what to hook themselves up to (because this makes for a new API than always passingthis
as the 1st arg of every proepty).So, properties got hooked up to "whatever random entity was last instantiated".
So we now fix-up the
currentlyInstantiatingEntity
in the getters: