fix: Fix factories defaulting tests when sinon is used. #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sinon's fake timers are installed, `global.Date` is mutated to its own `ClockDate` function, which breaks our equality check to the `field.type`, which will have captured the original `global.Date` value.
zgavin
approved these changes
May 3, 2024
stephenh
pushed a commit
that referenced
this pull request
May 3, 2024
## [1.163.4](v1.163.3...v1.163.4) (2024-05-03) ### Bug Fixes * Fix factories defaulting tests when sinon is used. ([#1068](#1068)) ([4651d07](4651d07))
|
🎉 This PR is included in version 1.163.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sinon's fake timers are installed,
global.Dateis mutated to its ownClockDatefunction, which breaks our equality check to thefield.type, which will have captured the originalglobal.Datevalue.