Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix lens over unloaded AsyncProperties. #1069

Merged
merged 1 commit into from May 3, 2024

Conversation

stephenh
Copy link
Collaborator

@stephenh stephenh commented May 3, 2024

The recent optimization of isLensLoaded moved from:

  • Just try and call .get and see if an exception is thrown

To:

  • Probe the path and look for explicitly not-loaded relations/properties

But I forgot to check for AsyncPropertys in the probe.

@stephenh stephenh merged commit a96582f into main May 3, 2024
4 checks passed
@stephenh stephenh deleted the fix-lens-loaded-for-properties branch May 3, 2024 14:49
stephenh pushed a commit that referenced this pull request May 3, 2024
## [1.163.5](v1.163.4...v1.163.5) (2024-05-03)

### Bug Fixes

* Fix lens over unloaded AsyncProperties. ([#1069](#1069)) ([a96582f](a96582f))
@stephenh
Copy link
Collaborator Author

stephenh commented May 3, 2024

🎉 This PR is included in version 1.163.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant