Added reactiveBeforeFlush #83
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zgavin
force-pushed
the
reactive-before-flush
branch
from
7017533
to
374424c
Compare
stephenh
reviewed
Dec 10, 2020
| return todo.metadata.config.__data.reversedHintsForReactiveHooks.map(async (reverseHint) => { | ||
| (await followReverseHint(entities, reverseHint)).forEach((entity) => { | ||
| const todo = getTodo(todos, entity); | ||
| if (!todo.reactiveHooks.includes(entity) && !entity.isDeletedEntity) { |
There was a problem hiding this comment.
Should we only push this into reactiveHooks if the entity is not already in entities, i.e. it will have its hooks fired anyway, and we might double fire the hook?
stephenh
force-pushed
the
main
branch
9 times, most recently
from
c936e48
to
7037a81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.