feat: Add preventEqualsOnEntities method for Jest. #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using toEquals with entities can cause issues b/c: * The equality does a deep comparison of the entities & ends up diffing the entire EntityManager/ConnectionPool * If equality fails, the toEquals diff similarily prints the entire entity + EntityManager + ConnectionPool While it's possible to add custom equality matchers, to recognize the entities and do a custom equals check, it's not possible to, if the entities are _not_ equal, provide a custom diff output. Because of this, we've created our own toMatchEntity, but it's hard to remember to use it, so this prompts the prompt by just breaking toEquals on entities all together.
stephenh
force-pushed
the
add-prevent-equals-on-entities
branch
from
6a939d0
to
1872475
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using toEquals with entities can cause issues b/c:
While it's possible to add custom equality matchers, to recognize the entities and do a custom equals check, it's not possible to, if the entities are not equal, provide a custom diff output.
Because of this, we've created our own toMatchEntity, but it's hard to remember to use it, so this prompts the prompt by just breaking toEquals on entities all together.