feat: Add wsl-send-notify for WSL based Linux #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
reviewed
Apr 3, 2024
pyrech
reviewed
Apr 3, 2024
TheoD02
force-pushed
the
feat/add_wsl-send-notify
branch
3 times, most recently
from
38dcf7b
to
caa9eca
Compare
TheoD02
force-pushed
the
feat/add_wsl-send-notify
branch
from
caa9eca
to
e6944e6
Compare
|
I ensured the binary is the one from the linked project and added a readme and the license from the project. Thanks @TheoD02 for the PR 🙏 |
|
@TheoD02 I see that you added the new WslNotifySendNotifier in the Unix notifiers list. But on WSL, the factory looks for the Windows notifiers. So i doubt it works. Can you confirm whether this needs to be changed? |
Hello, Yes indeed, I don't remember why I put it in Unix 😯 Need to change that to Windows, actually it's incorrect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Added notification functionality for Windows Subsystem for Linux (WSL). Allows notifications to be sent using the wsl-notify-send command, with support for defining title, body.
I implemented it quickly, ready for review :)
Related to this issue