Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor public notifiers into internal drivers #104

Merged
merged 2 commits into from
May 3, 2024
Merged

Refactor public notifiers into internal drivers #104

merged 2 commits into from
May 3, 2024

Conversation

pyrech
Copy link
Member

@pyrech pyrech commented Apr 25, 2024 •
edited

  • Deprecated all the notifiers classes
  • Deprecated the NotifierFactory in favor of a new NotifierInterface and a DefaultNotifier
  • The DefaultNotifier now lazyloads the better driver to avoid running processes too soon
  • Added a complete BC layer between both system
  • Mark most of the classes as internal

Todo:

  • Update the documentation
  • Add tests for the new DefaultNotifier

@pyrech pyrech force-pushed the refacto-everything branch 3 times, most recently from 7f01ad7 to 10a5b87 Compare April 25, 2024 23:16
@pyrech pyrech marked this pull request as ready for review April 26, 2024 06:51
@pyrech pyrech force-pushed the refacto-everything branch 6 times, most recently from 5733a7b to 634e586 Compare April 29, 2024 21:44
@lyrixx
Copy link
Member

lyrixx commented May 3, 2024

Overall design seems good 👍🏼 I didn't review this PR really well, but let's merge it 👍🏼

@pyrech pyrech force-pushed the refacto-everything branch 2 times, most recently from 1912a76 to 14252be Compare May 3, 2024 12:03
@pyrech pyrech merged commit 6fdce6b into main May 3, 2024
6 checks passed
@pyrech pyrech deleted the refacto-everything branch May 3, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pyrech @lyrixx