Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update some actions version #99

Merged
merged 3 commits into from Mar 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/ci.yaml
Expand Up @@ -2,40 +2,40 @@ name: CI

on:
push:
branches: [ main ]
branches: [main]
pull_request:
schedule:
- cron: '0 0 * * MON'
- cron: "0 0 * * MON"

jobs:
check-cs:
name: Check Coding Standards
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: PHP-CS-Fixer
uses: docker://oskarstark/php-cs-fixer-ga
with:
args: --config=.php-cs-fixer.php --diff --dry-run
args: --config=.php-cs-fixer.php --diff --dry-run

ci:
name: Test PHP ${{ matrix.php-version }} ${{ matrix.name }}
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
php-version: ['8.2', '8.3']
composer-flags: ['']
name: ['']
php-version: ["8.2", "8.3"]
composer-flags: [""]
name: [""]
include:
- php-version: 8.1
composer-flags: '--prefer-lowest'
name: '(prefer lowest dependencies)'
composer-flags: "--prefer-lowest"
name: "(prefer lowest dependencies)"
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup PHP, with composer and extensions
uses: shivammathur/setup-php@v2
Expand Down
4 changes: 3 additions & 1 deletion src/Exception/Exception.php
Expand Up @@ -11,4 +11,6 @@

namespace Joli\JoliNotif\Exception;

interface Exception {}
interface Exception
{
}
2 changes: 1 addition & 1 deletion src/Exception/InvalidNotificationException.php
Expand Up @@ -21,7 +21,7 @@ public function __construct(
Notification $notification,
$message = '',
$code = 0,
Exception $previous = null
?Exception $previous = null
) {
$this->notification = $notification;

Expand Down
2 changes: 1 addition & 1 deletion src/Exception/NoSupportedNotifierException.php
Expand Up @@ -16,7 +16,7 @@ class NoSupportedNotifierException extends \RuntimeException implements Exceptio
public function __construct(
$message = 'No supported notifier',
$code = 0,
Exception $previous = null
?Exception $previous = null
) {
parent::__construct($message, $code, $previous);
}
Expand Down
4 changes: 3 additions & 1 deletion src/Util/OsHelper.php
Expand Up @@ -16,4 +16,6 @@
/**
* @deprecated since 2.6, use OsHelper from jolicode/php-os-helper instead
*/
class OsHelper extends BaseOsHelper {}
class OsHelper extends BaseOsHelper
{
}