Deprecate the ability to inject AST transformer factories withing stand-alone AutoMapper #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Korbeil
force-pushed
the
feature/allow-register-custom-ast-transformers
branch
from
489a76a
to
1ad7432
Compare
Korbeil
force-pushed
the
feature/allow-register-custom-ast-transformers
branch
from
1ad7432
to
b71d642
Compare
|
Is there really a need for that ? It requires also removing internal on those interfaces which extends the API a lot for a feature that is really complicated for end user and you can do everything with the current transformer interface ? Do you have a use case for that ? |
|
We talked about it with @joelwurtz and decided to remove this feature (deprecating it at first). |
Korbeil
changed the title
Korbeil
force-pushed
the
feature/allow-register-custom-ast-transformers
branch
from
ac5fdcb
to
f937daf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.