chore(test): allow to run symfony app in tests #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelwurtz
force-pushed
the
feat/bundle-app
branch
from
99a4f2c
to
f83934a
Compare
lyrixx
reviewed
Mar 22, 2024
| @@ -31,8 +31,12 @@ | |||
| "symfony/filesystem": "^5.4 || ^6.0 || ^7.0", | |||
| "symfony/framework-bundle": "*", | |||
| "symfony/http-kernel": "^5.4 || ^6.0 || ^7.0", | |||
| "symfony/property-access": "^5.4 || ^6.0 || ^7.0", | |||
There was a problem hiding this comment.
IMHO, you should use 6.4 everywhere, 6.0..6.3 are EOL
There was a problem hiding this comment.
As long as we support 5.4 there i think any 6 version will work, let's be nice to people that didn't upgrade yet
There was a problem hiding this comment.
That's weird. There is no reason to upgrade from 5.4 to 6.0. the correct things to do is 5.4 to 6.4
Anyway, not a big deal
There was a problem hiding this comment.
More than someone still in 6.1 that want to install this bundle
joelwurtz
force-pushed
the
feat/bundle-app
branch
from
f83934a
to
9f7d250
Compare
joelwurtz
force-pushed
the
feat/bundle-app
branch
from
9f7d250
to
9e749fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.