Change $this to self in generate-tests.php for method assertStringEqualsFile in TaskTestCase
#304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngEqualsFile` in TaskTestCase
TheoD02
force-pushed
the
fix/change_this_to_self_call_for_task_test_case
branch
from
347583e
to
2091ded
Compare
lyrixx
reviewed
Mar 4, 2024
There was a problem hiding this comment.
I'm against this change. It's really a matter of personal test. And I prefer to stick to the same way of doing it as in the phpunit documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the tests,
$this->assertStringEqualsFilewas replaced withself::assertStringEqualsFile. The change was necessary because the methodassertStringEqualsFileis static. This ensures a more proper and standard use of static method invocation in PHP.