Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repack - Add local box.json support #318

Merged
merged 1 commit into from Mar 10, 2024
Merged

Repack - Add local box.json support #318

merged 1 commit into from Mar 10, 2024

Conversation

SebLours
Copy link
Contributor

@SebLours SebLours commented Mar 9, 2024 •
edited

Issue #305 - Add support for local box.json config file.

For example:

{
    "files": [
        "vendor/twig/twig/src/TwigTest.php"
    ]
}

@SebLours SebLours mentioned this pull request Mar 9, 2024
Closed
lyrixx
lyrixx reviewed Mar 9, 2024
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very simple, I like it.

Could you update the changelog and add some documentation?

Thanks

@SebLours SebLours marked this pull request as draft March 9, 2024 12:02
@SebLours
Copy link
Contributor Author

SebLours commented Mar 9, 2024

I do a mistake...
I want to merge a box.json file for the root directory and not the Castor sources.
I'll fix it!

@SebLours
Copy link
Contributor Author

I need more logic to prevent merging some scalar config values defined by Castor.
array_merge_recursive transforms scalar values to array, breaking the config shema.

@SebLours SebLours marked this pull request as ready for review March 10, 2024 09:41
lyrixx
lyrixx approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks

pyrech
pyrech approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@pyrech pyrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@pyrech pyrech merged commit 4cb17df into jolicode:main Mar 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

@pyrech pyrech pyrech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SebLours @lyrixx @pyrech