Add support for getting raw parameters without validation

[lyrixx]

Example :

#[AsTask(ignoreValidationErrors: true)]
function ls(): void
{
    $params = input()->getRawParameters();
    // remove command name
    array_shift($params);
    run(['ls', ...$params], tty: true);
}

[pyrech]

Do you have a usecase in mind?

[lyrixx]

See symfony/symfony#54238

Yes! @tlenclos needs that. (I asked a ticket but... no shame 😂)

Anyway, this is very useful for such cases:

castor phpunit
castor phpunit --filter testFoobar
castor phpunit -v -d

same for MANY commands actually !

[lyrixx]

• RFR
• I updated the description with a real word usecase

[lyrixx]

Should I ship that?

#[AsTask(ignoreValidationErrors: true)]
function ls(#[AsRawTokens] array $extraParam): void
{
    run(['ls', ...$extraParam], tty: true);
}

Implementation

diff --git a/src/Attribute/AsRawTokens.php b/src/Attribute/AsRawTokens.php
new file mode 100644
index 0000000..3071806
--- /dev/null
+++ b/src/Attribute/AsRawTokens.php
@@ -0,0 +1,8 @@
+<?php
+
+namespace Castor\Attribute;
+
+#[\Attribute(\Attribute::TARGET_PARAMETER)]
+class AsRawTokens
+{
+}
diff --git a/src/Console/Command/TaskCommand.php b/src/Console/Command/TaskCommand.php
index adefbb2..a6ccf52 100644
--- a/src/Console/Command/TaskCommand.php
+++ b/src/Console/Command/TaskCommand.php
@@ -5,8 +5,10 @@ namespace Castor\Console\Command;
 use Castor\Attribute\AsArgument;
 use Castor\Attribute\AsCommandArgument;
 use Castor\Attribute\AsOption;
+use Castor\Attribute\AsRawTokens;
 use Castor\Attribute\AsTask;
 use Castor\Console\Application;
+use Castor\Console\Input\Input;
 use Castor\Event\AfterExecuteTaskEvent;
 use Castor\Event\BeforeExecuteTaskEvent;
 use Castor\EventDispatcher;
@@ -81,6 +83,10 @@ class TaskCommand extends Command implements SignalableCommandInterface
         }
 
         foreach ($this->function->getParameters() as $parameter) {
+            if ($parameter->getAttributes(AsRawTokens::class, \ReflectionAttribute::IS_INSTANCEOF)[0] ?? null) {
+                continue;
+            }
+
             $taskArgumentAttribute = $parameter->getAttributes(AsCommandArgument::class, \ReflectionAttribute::IS_INSTANCEOF)[0] ?? null;
 
             if ($taskArgumentAttribute) {
@@ -144,11 +150,23 @@ class TaskCommand extends Command implements SignalableCommandInterface
         }
     }
 
+    /**
+     * @param Input $input
+     */
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $args = [];
 
         foreach ($this->function->getParameters() as $parameter) {
+            if ($parameter->getAttributes(AsRawTokens::class, \ReflectionAttribute::IS_INSTANCEOF)[0] ?? null) {
+                $parameters = $input->getRawParameters();
+                // Remove command name
+                array_shift($parameters);
+                $args[] = $parameters;
+
+                continue;
+            }
+
             $name = $this->getParameterName($parameter);
             if ($input->hasArgument($name)) {
                 $args[] = $input->getArgument($name);

[lyrixx]

Shipped

[pyrech]

I really like the usecase, thanks.

Could you add some documentation about it?

[lyrixx]

Oups, totally forgot the doc. Sorry! Is it better?

[joelwurtz]

Really nice thanks you @lyrixx

[tlenclos]

Thanks ❤️