Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid suggesting echo in documentation and examples #324

Merged
merged 1 commit into from Mar 12, 2024

Conversation

pyrech
Copy link
Member

@pyrech pyrech commented Mar 12, 2024

As explained in our doc, echo is not recommended. Doc and examples were updated to reflect that:

  • replaced all calls to echo php instruction by io()->writeln()
  • replaced almost all calls to echo bash command by io()->writeln() (some were kept when showing env vars behaviour, run events, etc)

Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thanks

@pyrech pyrech merged commit 555c0f1 into main Mar 12, 2024
9 checks passed
@pyrech pyrech deleted the avoid-echo-examples branch March 12, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants