Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on installation inside WSL #334

Merged
merged 1 commit into from Mar 20, 2024
Merged

Add note on installation inside WSL #334

merged 1 commit into from Mar 20, 2024

Conversation

pyrech
Copy link
Member

@pyrech pyrech commented Mar 20, 2024

No description provided.

@TheoD02
Copy link
Contributor

TheoD02 commented Mar 20, 2024

Hey, I've already used PHAR on a WSL system without problem, what's the reason to prefer Windows PHAR ? Notification ?

@pyrech pyrech force-pushed the doc-installation-wsl branch 3 times, most recently from f3a6cc8 to 9d3fbfc Compare March 20, 2024 14:50
@pyrech
Copy link
Member Author

pyrech commented Mar 20, 2024

Yep, exactly, by using the linux phar, you end up using a phar without the windows notification binaries, so it break Castor/JoliNotif. But everything is still working well, yes 馃憤

@pyrech pyrech force-pushed the doc-installation-wsl branch 2 times, most recently from 9d3fbfc to 3c767cb Compare March 20, 2024 14:59
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@lyrixx lyrixx merged commit 3ce7c3f into main Mar 20, 2024
9 checks passed
@lyrixx lyrixx deleted the doc-installation-wsl branch March 20, 2024 15:00
@TheoD02
Copy link
Contributor

TheoD02 commented Mar 20, 2024

Interesting, I'd actually had the problem a time ago.

But on my side it works with the PHAR for linux currently under WSL, see the screen.

image

It certainly affects a previous version of WSL.

Here my WSL and Windows specs:

Version WSL : 2.1.4.0
Version du noyau : 5.15.146.1-2
Version WSLg : 1.0.60
Version MSRDC : 1.2.5105
Version direct3D : 1.611.1-81528511
Version de DXCore : 10.0.25131.1002-220531-1700.rs-onecore-base2-hyp
Version de Windows : 10.0.22631.3296

@lyrixx
Copy link
Member

lyrixx commented Mar 20, 2024

Are you 100% sure your current screen shot use the phar you just downloaded?
we don't see the moment when you ran a castor script.

@TheoD02
Copy link
Contributor

TheoD02 commented Mar 20, 2024

Yes, in fact, I tested with my linux phar version, then with the windows phar, and rollback to linux for the screen.
All 3 worked fine

edit:
Is the problem you've been told relates to a stable, non-pre-release version of WSL?

Also, does WSL use the new syntax for path \wsl$ or \wsl.localhost?

@pyrech
Copy link
Member Author

pyrech commented Mar 20, 2024

In both cases (linux and windows phar), you get a notification through SnoreToast?

@pyrech
Copy link
Member Author

pyrech commented Mar 20, 2024

Is the problem you've been told relates to a stable, non-pre-release version of WSL?

Also, does WSL use the new syntax for path \wsl$ or \wsl.localhost?

No idea, it's a report we got internally but we don't have the information AFAIK

@TheoD02
Copy link
Contributor

TheoD02 commented Mar 20, 2024

In both cases (linux and windows phar), you get a notification through SnoreToast?

Yep (the toast is not visible on the video due to screen recording, but it is displayed in both cases)

fish._home_t_projects_castor.2024-03-20.16-29-18.mp4

No idea, it's a report we got internally but we don't have the information AFAIK

Interesting, but I did have a problem previously, I remember, but not any more.
But I admit I don't use notify in my scripts, so I didn't look any further for a solution.

@pyrech
Copy link
Member Author

pyrech commented Mar 20, 2024

Are you 100% sure that when you run castor it uses the binary just downloaded and moved to /usr/local/bin and not a previously installed one? Could you retry by executing the binary downloaded without moving it first?

@TheoD02
Copy link
Contributor

TheoD02 commented Mar 20, 2024

Are you 100% sure that when you run castor it uses the binary just downloaded and moved to /usr/local/bin and not a previously installed one? Could you retry by executing the binary downloaded without moving it first?

Yes, I did retest with both without moving them, it works correctly having run php castor.<linux|windows>-amd64.phar notify:send-notify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants