Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better minimum version exception message #337

Merged
merged 1 commit into from Mar 21, 2024

Conversation

pyrech
Copy link
Member

@pyrech pyrech commented Mar 21, 2024

The new message better shows to users that this is a requirement from the current project, not Castor itself

Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very much better.
But tests are broken

@pyrech pyrech force-pushed the better-min-guard-version-message branch from 7e1d1fc to ae29d6f Compare March 21, 2024 11:10
@pyrech pyrech merged commit c489fb7 into main Mar 21, 2024
9 checks passed
@pyrech pyrech deleted the better-min-guard-version-message branch March 21, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants