Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure reference documentation is up to date #452

Merged
merged 3 commits into from
May 14, 2024
Merged

Ensure reference documentation is up to date #452

merged 3 commits into from
May 14, 2024

Conversation

pyrech
Copy link
Member

@pyrech pyrech commented May 5, 2024

No description provided.

Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

tests/Doc/ReferenceTest.php Outdated Show resolved Hide resolved
tests/Doc/ReferenceTest.php Outdated Show resolved Hide resolved
@pyrech pyrech force-pushed the test-reference branch 2 times, most recently from 2cba22b to f7baa45 Compare May 13, 2024 17:25
@pyrech
Copy link
Member Author

pyrech commented May 13, 2024

Comments addressed. And I added another check to ensure lists are well sorted.

Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 馃憤馃徏

tests/Doc/ReferenceTest.php Outdated Show resolved Hide resolved
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pyrech
Copy link
Member Author

pyrech commented May 14, 2024

PHPStan failure seems unrelated

@lyrixx lyrixx merged commit 0e59ed9 into main May 14, 2024
8 of 9 checks passed
@lyrixx lyrixx deleted the test-reference branch May 14, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants