Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a docker registry for cache #283

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

joelwurtz
Copy link
Member

@joelwurtz joelwurtz commented Feb 27, 2024

Fix #252

WHat it does :

  • remove USER_ID features from dockerfile: Without this change the USER_ID make the image dependant on the system that run this command wich creates differents images and make them not shareable
  • run frontend / builder / worker as a specific user id : we don't use a named user anymore to avoid headcache when mapping it to a different user id
  • local and shared home directory : This allow to debug home directory and files created in it (like composer cache), allow end users to put special scripts in it (like a custom bashrc), and also allow to cache this folder or specific subfolders of this directory within the CI (like the composer / yarn cache)
  • command to generate a bake file which allow to push images to the registry
  • sudo : it use gosu to fake it since we don't have a named user, it also disable by default as it may be a security risk if image is used in production

@joelwurtz joelwurtz marked this pull request as ready for review April 25, 2024 14:32
@joelwurtz joelwurtz force-pushed the feat/registry-docker branch 2 times, most recently from bdb2222 to 935e24f Compare April 26, 2024 14:16
@lyrixx
Copy link
Member

lyrixx commented May 3, 2024

Is there a simple way to get sudo back? I need it quiet often

.castor/docker.php Show resolved Hide resolved
.castor/docker.php Outdated Show resolved Hide resolved
.castor/docker.php Outdated Show resolved Hide resolved
.castor/docker.php Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
infrastructure/docker/services/php/Dockerfile Show resolved Hide resolved
infrastructure/docker/services/php/Dockerfile Show resolved Hide resolved
infrastructure/docker/services/php/Dockerfile Show resolved Hide resolved
@joelwurtz
Copy link
Member Author

joelwurtz commented May 3, 2024

Is there a simple way to get sudo back? I need it quiet often

done

Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

.castor/docker.php Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a default Docker registry or layer cache by default
4 participants