Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generate-certificates namespace #288

Merged
merged 1 commit into from Mar 7, 2024
Merged

fix: generate-certificates namespace #288

merged 1 commit into from Mar 7, 2024

Conversation

JorickPepin
Copy link
Member

No description provided.

lyrixx
lyrixx reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! thanks. I let one little comment tho

.castor/docker.php Outdated Show resolved Hide resolved
@JorickPepin JorickPepin force-pushed the fix_generate-certificates-namespace branch from 4dfb8b1 to f45ca81 Compare March 7, 2024 13:36
pyrech
pyrech approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@pyrech pyrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pyrech pyrech merged commit 10953cf into main Mar 7, 2024
4 checks passed
@pyrech pyrech deleted the fix_generate-certificates-namespace branch March 7, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx left review comments

@pyrech pyrech pyrech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JorickPepin @lyrixx @pyrech